Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let dependencies in the pyproject.toml float upwards to reduce depencency version conflicts #2079

Closed
wants to merge 2 commits into from

Conversation

uckelman-sf
Copy link
Contributor

Let dependencies in the pyproject.toml float upwards to reduce conflicts when using capa as a library. Added requirements.txt to continue pinning dependency versions for release builds.

Resolves #2053.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

when using capa as a library. Added requirements.txt to continue pinning
dependency versions for release builds.
Copy link

google-cla bot commented May 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, with a few recommendations inline.

thanks @uckelman-sf!

pyproject.toml Outdated Show resolved Hide resolved
"dncil==1.0.2",
"pydantic==2.7.1",
"protobuf==5.26.1",
"tqdm>=4.66.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you please add a comment that indicates something like "the following minimum dependency versions were imported in May 2024".

then if we have to bump some versions up, or otherwise restrict, we can move those to another section so that it's clear which are "hard" lower limits and which happen to be snapshots from today.

does this make sense? open to discussion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense.

@sf-jonstewart
Copy link

Howdy! I... reaaaaaaaaaaalllllllllllllly... don't want to take three months of conference calls to sign a stupid CLA for some greater-than signs. Please consider this a well-specified bug report. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flare-capa is incompatible with flare-floss 3.1.0
3 participants