Kill remote process #953
Merged
Kill remote process #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
werhner
commented
May 23, 2024
werhner
commented
- add option lsp-bridge-remote-enable-kill-process, which can kill remote lsp-bridge process when Emacs exit
- add option acm-backend-ctags-max-candidates
- add command lsp-bridge-ctags-find-def-at-point, which uses xref as front-end.
acm/acm-backend-codeium.el
Outdated
Comment on lines
163
to
168
| (let ((end-position (line-end-position))) | ||
| (let ((start-position (line-beginning-position)) | ||
| (middle-position (point))) | ||
| (forward-line (- (plist-get candidate-info :line) (count-lines (point-min) (line-beginning-position)))) | ||
| (if preview | ||
| (acm-preview-create-overlay (point) end-position (plist-get candidate-info :label)) | ||
| (delete-region (point) end-position) | ||
| (acm-preview-create-overlay start-position middle-position (plist-get candidate-info :label)) | ||
| (delete-region start-position middle-position) |
manateelazycat
requested changes
May 23, 2024
lsp-bridge.el
Outdated
Comment on lines
2149
to
2180
| (defface lsp-bridge-tag-annotation-face | ||
| '((((background light)) | ||
| :foreground "#666666" :slant italic) | ||
| (t | ||
| :foreground "#c0c0c0" :slant italic)) | ||
| "Face used for annotations when presenting a tag. | ||
| Annotations include kind, type, etc.") | ||
|
|
||
| (defun lsp-bridge-xref--make-object (tag) | ||
| "Make xref object of TAG." | ||
| (let* ((path (plist-get tag :ext-abspath)) | ||
| (line (plist-get tag :line)) | ||
| (str (plist-get tag :str)) | ||
| (annotation (plist-get tag :annotation))) | ||
| (xref-make | ||
| (if annotation | ||
| (concat (propertize (concat "(" annotation ") ") 'face 'lsp-bridge-tag-annotation-face) str) | ||
| str) | ||
| (xref-make-file-location path line 0)))) | ||
|
|
||
| (defun lsp-bridge-xref-callback (tags) | ||
| (let ((fetcher (lambda () (mapcar #'lsp-bridge-xref--make-object tags)))) | ||
| (xref-show-xrefs fetcher nil))) | ||
|
|
||
| (defun lsp-bridge-ctags-find-def-at-point () | ||
| (interactive) | ||
| (if (lsp-bridge-is-remote-file) | ||
| (lsp-bridge-remote-send-func-request "ctags_find_def" | ||
| (list | ||
| (symbol-at-point) | ||
| (file-local-name (buffer-file-name)))) | ||
| (lsp-bridge-call-async "ctags_find_def" (symbol-at-point) (buffer-file-name)))) |
There was a problem hiding this comment.
Those code should move to file acm-backend-ctags.el , and rename with acm-backend-ctags-*
Comment on lines
+836
to
+840
| def close_client(self): | ||
| for client in self.client_dict.values(): | ||
| if hasattr(client, "kill_lsp_bridge_process"): | ||
| client.kill_lsp_bridge_process() | ||
|
|
There was a problem hiding this comment.
Why not add close_client code to function "cleanup" ?
lsp-bridge.el
Outdated
Comment on lines
1137
to
1138
| (when lsp-bridge-remote-enable-kill-process | ||
| (lsp-bridge-call-sync "close_client")) |
There was a problem hiding this comment.
Shoud remove those code if code of close_client move to "cleanup" function.
And don't use lsp-bridge-call-sync, it will block Emacs.
lsp-bridge.el
Outdated
Comment on lines
1006
to
1010
| (defun lsp-bridge-call-sync (method &rest args) | ||
| "Call Python EPC function METHOD and ARGS synchronously." | ||
| (lsp-bridge-deferred-chain | ||
| (lsp-bridge-epc-call-sync lsp-bridge-epc-process (read method) args))) | ||
|
|
There was a problem hiding this comment.
Don't use this function, it will block Emacs
|
Thanks for patch, I have review code, need adjust. ;) |
|
Thanks for the review, I'll try to adjust these in my spare time. |
|
@werhner Please let me know if this patch can be merged, thank you |
manateelazycat
requested changes
Jun 2, 2024
| "Maximal number of candidate of menu." | ||
| :type 'integer | ||
| :group 'acm-backend-ctags) | ||
| (require 'xref) |
manateelazycat
requested changes
Jun 4, 2024
Comment on lines
+842
to
843
| self.close_client() | ||
| """Do some cleanup before exit python process.""" |
There was a problem hiding this comment.
close_client should move to below of function comment
|
@werhner Please adjust code when you have time. I will merge your patch as soon as possible. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.