Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Sobralik Pet Water Fountain #1846

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

edev-us
Copy link

@edev-us edev-us commented Apr 22, 2024

I added support for Sobralik Pet Water Fountain

Included support for all properties / abilities.

Protocol: 3.3

image

name: fault
type: bitfield
mapping:
- dps_val: 0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the value for no fault? Normally that would be 0. If these are bit numbers from the tuya documentation, then the values should be 1, 2 and 4.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query is blocking for merge

@@ -0,0 +1,104 @@
name: Sobralik Pet Water Fountain
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branding should be under products below, preferably including a model name or number as well.
This top level name should be generic and following HA naming convention only the first word capitalised: "Pet water fountain"

range:
min: 0
max: 90
unit: Days
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit should be d for days.

min: 0
max: 31
unit: Days
- entity: sensor
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are only two values, this could be made into a binary_sensor, with translation_key: tank_empty, with level_1 mapped to true and level_2 mapped to false. This could then b easily used in automations to notify to fill the tank, and would also get the translations that are already there for tank_empty.

@make-all make-all added the awaiting feedback Needs more information label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Needs more information
Projects
Status: 🏗 Stalled
Development

Successfully merging this pull request may close these issues.

None yet

2 participants