Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public properties for php 8.2 support #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

earthiverse
Copy link

Description

Similar to #348, but for the marketing API

See https://php.watch/versions/8.2/dynamic-properties-deprecated for why this is necessary.

Copy link

cla-bot bot commented Feb 13, 2024

Contributor License Agreement Instructions
Thanks for your pull request. Before we can review your work, you’ll need to sign a Contributor License Agreement (CLA).

Please download the appropriate CLA below. Once downloaded, please read, sign, and send back to us at [email protected]. Please note, this account is not monitored so please visit https://mailchimp.com/contact/ if you need support.

Individual CLA: Mailchimp Individual CLA
Corporate CLA: Mailchimp Corporate CLA

Once you’ve emailed us the signed CLA, please reply here (e.g. CLA signed and sent!) and we’ll verify it.

What to do if you already signed the CLA
Individual signers
• If you’ve previously sent us a signed CLA, please reply here letting us know and we’ll verify. If we are unable to verify, It’s possible we don’t have your GitHub username or you’re using a different email address on your Git commit. Check that the CLA you previously submitted was sent to us using the email address associated with your GitHub username and verify that your email is set on your Git commits.
Corporate signers
• Your company has a Point of Contact (POC) who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you’ve previously sent us an updated CLA, please reply here letting us know and we’ll verify.
• The email used to register you as an authorized contributor must be the email used for the Git commit.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

@earthiverse
Copy link
Author

CLA signed and sent!

@earthiverse
Copy link
Author

@sheetal-purple @webkod3r Sorry for the tag, but is there any chance that this could be looked at?
This is blocking us from upgrading to PHP 8.2.

Also, I was wondering if CODEOWNERS is up-to-date.

@webkod3r
Copy link
Contributor

@sheetal-purple @webkod3r Sorry for the tag, but is there any chance that this could be looked at? This is blocking us from upgrading to PHP 8.2.

Also, I was wondering if CODEOWNERS is up-to-date.

Hello @earthiverse I'm currently out of office but I'll redirect this to proper channels to get this fixed.
Lastly, you are correct. The list of code owners is not up to date.

@olsp
Copy link

olsp commented Jun 11, 2024

Hi. I wanted to ask what the status of this is? It seems like https://github.com/mailchimp/mailchimp-marketing-php hasn't been updated yet.

@webkod3r
Copy link
Contributor

Hi. I wanted to ask what the status of this is? It seems like https://github.com/mailchimp/mailchimp-marketing-php hasn't been updated yet.

Hi @olsp, I'm working supporting the Transactional API both for PHP as well as Javascript. I've communicated this concern to the team taking care of marketing API. I'll chat with them today. Please accept my apologies on behalf of them.

@dregad
Copy link

dregad commented Jun 15, 2024

Thanks @webkod3r for your support. Did you get any feedback from the team ?

As mentioned, this is blocking upgrade to PHP 8.2, which was released 1 year, 6 months ago so it would be much appreciated if Mailchimp could keep this library up-to-date with currently supported PHP releases, particularly when the only thing needed is merging a community-provided pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants