Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofetch: update to 20211210 (master branch) #24136

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

  • add revision and remove platforms line
  • add myself as co-maintainer
  • disable livecheck

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 3.2.6 10M2518

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* add revision and remove platforms line
* add myself as co-maintainer
* disable livecheck
@macportsbot
Copy link

Notifying maintainers:
@rangeles for port neofetch.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port labels May 26, 2024
@rangeles
Copy link
Contributor

Hi, I'd like to reject this pull request. I always had the intention of keeping neofetch on whatever was the latest stable release, which is still 7.1.0.

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@rangeles current version of this script does not contain fixes for Apple Silicon machines that have them in the master branch. It is also unknown when a new version will be released, as the developer has “taken up farming” and the repository is archived.

@TheRealKeto
Copy link
Contributor

TheRealKeto commented May 29, 2024

@aeiouaeiouaeiouaeiouaeiouaeiou There are various alternatives that have support for Apple Silicon. If MacPorts is to continue to distribute neofetch, there are several approaches

  1. Bless a new upstream (like hyfetch, which does maintain a neofetch script by merging pull requests made to the original project onto a fork) or

  2. Have the latest commit be a new subport and add notes to the stable port regarding the fact that it doesn't contain newer fixes due to a lack of a newer release

Though hyfetch already exists as its own standalone port, the version of neofetch they host is renamed to neowofetch (and frankly, there's no need to download the entire project in a new port again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
4 participants