Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lux: update to 0.24.1 #24133

Merged
merged 1 commit into from
May 29, 2024
Merged

lux: update to 0.24.1 #24133

merged 1 commit into from
May 29, 2024

Conversation

herbygillot
Copy link
Member

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install sudo port -d destroot?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@l2dy for port lux.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels May 25, 2024
l2dy
l2dy reviewed May 26, 2024
View reviewed changes
net/lux/Portfile
sha256 b3e70a63ad5053b37f95f717c97df6d8d57e4b63abf46df88a06d1cca4fa5443 \
size 103624

go.vendors gopkg.in/yaml.v3 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed? Is vendoring dependencies no longer possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into some issues trying to vendor this version, and just chose not to deal with the struggle of getting it to work.

@pmetzger pmetzger merged commit f40a017 into macports:master May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2dy l2dy l2dy left review comments

Assignees

@l2dy l2dy

Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update
Milestone
No milestone
4 participants
@herbygillot @macportsbot @l2dy @pmetzger