Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of multi line title and description #81

Conversation

cyberixae
Copy link
Contributor

@cyberixae cyberixae commented Jun 1, 2023

This pull request fixes #79 by generating a separate line comment for each line of JSON schema title and description. This approach has the benefit that existing non-multi-line conversions won't change as a result.

@cyberixae
Copy link
Contributor Author

The solution suggested in pull request #80 attempts to solve the problem by use of multi line comments /* comment */. While this would work for line-endings it creates a new problem for descriptions containing */ that might prematurely end the multi-line comment.

@cyberixae cyberixae merged commit 43e7d48 into maasglobal:main Aug 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline descriptions generate syntax issues
1 participant