pe.import: Add get_imports_rva to SynthethicImportDirectoryEntry #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an extra function called
get_imports_rva
To be honest I'm not sure about the correct interface so I'm leaving it like this and opening it to the discussion.
I've separated
get_imports_rva
according to the discussion in #171 , As saving this information was consideredwasteful
since it's easily calculated.The problem with this function is that it needs to know the bitness of the PE (whether it's 32bit or 64bit) to properly calculate the RVAs.
Also, I started working with rust a few days ago, so any tips or comments are more than welcome.
Thanks!