etcd_docker 6: Remove etcd embed from M3DB node #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2023
justinjc
approved these changes
Mar 22, 2023
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/4825f7a5
branch
from
9c7b317
to
d97f0e4
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
0bdd1bf
to
e6f1295
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/4825f7a5
branch
from
d97f0e4
to
4350d8f
Compare
PR 6 for #4144 Now that all test usages of the embed package had been removed, this PR removes the usage of the embed package from the m3db server itself. N.B.: this PR currently makes no attempt to fix up any "quick start" flows relying on embedded etcd; that will come later. commit-id:4825f7a5
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/e67a5172
branch
from
e6f1295
to
abd72e3
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/4825f7a5
branch
from
4350d8f
to
b0b19f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 6 for #4144
Now that all test usages of the embed package had been removed, this PR removes
the usage of the embed package from the m3db server itself.
N.B.: this PR currently makes no attempt to fix up any "quick start" flows relying on embedded etcd; that will
come later.
Stack: