Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A cli version #18

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

HackerAIOfficial
Copy link

You did an amazing job.

But most people wants a cli version to quickly get started and play around.

Here it is.

Cheers.

@@ -0,0 +1,325 @@
#!/usr/bin/env python3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'd rather refactor the main.py one to accept cli args

@daegalus
Copy link

daegalus commented Apr 4, 2023

I will say, I would rather keep the implementations cleaner for learning purposes. This is one of the easiest to grasp and understand repo on how to fine tune a project, and is a great learning example.

If anything, it should be split into 3 files. tuner.py which has the functions and extras that are the core. web.py which has the webserver code and calls tuner.py functions. and cli.py for handling cli args, and calls tuner.py.

Obviously as the author you can choose what you want, but for those coming to your repo as one of the few easy examples of fine tuning, it might be better to keep things cleanly laid out instead of lumped into 1 file.

@tensiondriven
Copy link

If it's possible to add a separate file that can be invoked to do CLI training, i would love that. I am currently attempting to run training via CLI; I will have a look at this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants