Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix issue with environmental variables. #108

Merged
merged 2 commits into from
Dec 15, 2017
Merged

Conversation

nkabir
Copy link
Contributor

@nkabir nkabir commented Dec 15, 2017

Moving config.interpolate() before schema check to support interpolated variables in configuration file to address issue #107

All tests pass.

@ghost
Copy link

ghost commented Dec 15, 2017

@nkabir thanks for this PR. As we say in #106, @ellmetha and I aren't maintaining this project anymore. @robvdl stepped in but he isn't sure if he'd be able to do it on his own. Would you be interested in stepping in?

@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          45       45           
  Lines        1269     1269           
=======================================
  Hits         1186     1186           
  Misses         83       83
Impacted Files Coverage Δ
lxdock/conf/config.py 98.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0f098...56fbc42. Read the comment docs.

@nkabir
Copy link
Contributor Author

nkabir commented Dec 15, 2017

Sure. It would be helpful to have one or more people that have a history with the project to be available for occasional questions. It's a nice library and fits my needs quite well. I don't anticipate needing new features but would consider it a shame if it went unmaintained. If @robvdl will also be involved, we may be able to keep it alive.

@ghost
Copy link

ghost commented Dec 15, 2017

@nkabir great, you're in!

I'll be available if you have questions or want to release a version, but otherwise I'm not planning on reviewing incoming PR.

@nkabir
Copy link
Contributor Author

nkabir commented Dec 15, 2017

Understood. That should be fine. Thank you for a great library!

@robvdl
Copy link
Member

robvdl commented Dec 15, 2017

Hi @nkabir thanks for your PR, and welcome aboard.

I plan on getting a bit more involved after Christmas as I have just one more week of work and then a month off, I only just got access myself just like you.

@nkabir
Copy link
Contributor Author

nkabir commented Dec 15, 2017

Looking forward to it, @robvdl

@nkabir nkabir merged commit 1d1d8e8 into lxdock:master Dec 15, 2017
@robvdl
Copy link
Member

robvdl commented Dec 15, 2017

Although I did see this commit and it's pretty small and it's probably fine, I was going to try to merge it over the weekend. We should probably at least try to avoid self merging things into master, unless we merge into a develop branch it's OK.

One of the first things I wanted to change is not mark the project as unmaintained anymore.

We need to come up with some plans of how to go forward, what outstanding issues need to be resolved, or which ones don't make sense and just need to be answered.

I am pretty sure there is an IRC channel too, since we use IRC at work all day anyway, I will make a habit of being on there at least during work hours in NZ.

We should probably continue the conversation in #106 rather than here.

By the way @hsoft some people at work were excited to see a new maintainer to vagrant lxc, good luck with your work on that. I know they use a very custom version of vagrant and vagrant LXC now and are really excited to see vagrant LXC being worked on again, I doubt they want to be on this custom version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants