Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify the find_version script and fix shellcheck report in it #6133

Merged
merged 2 commits into from
May 3, 2024

Conversation

marex
Copy link
Contributor

@marex marex commented Apr 26, 2024

Use sed one-liner to extract the version without any temp files.

Fix the following shellcheck report. The cd builtin may fail, handle it gracefully.

In scripts/find_version.sh line 3:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
               ^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 || exit ; pwd -P )"

For more information:
  https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...

Marek Vasut added 2 commits April 26, 2024 19:57
Use sed one-liner to extract the version without any temp files.

Signed-off-by: Marek Vasut <[email protected]>
Fix the following shellcheck report. The cd builtin may fail, handle it gracefully.
"
In scripts/find_version.sh line 3:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
               ^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 || exit ; pwd -P )"

For more information:
  https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...
"

Signed-off-by: Marek Vasut <[email protected]>
@kisvegabor
Copy link
Member

kisvegabor commented Apr 28, 2024

Hey,

I've fixed tested it and it works well. Thank you!

@marex
Copy link
Contributor Author

marex commented May 1, 2024

Hey,

I've fixed tested it and it works well. Thank you!

@kisvegabor thank you.

I have noticed the MRs are all over the place, so let me try to create some sort of order in it:

Do I have it right ?

@kisvegabor
Copy link
Member

Yes, this issue have many branches now.

I'll merge this PR as a hotfix for non-Linux but #6135 should be superior.

I thought #6080 is not really related as it should help only in releasing to update the versions on all the places. However, with the help this scrip we can hardcode the version in the docs too, and update it with a script before releases.

cc @kdschlosser @becseya

@kisvegabor kisvegabor merged commit 9aa95c3 into lvgl:master May 3, 2024
19 checks passed
@kisvegabor
Copy link
Member

And we have #6143 too.

Finally #6080 should solve all the issues if the version id hardcoded in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants