Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsButton nextTick js error #918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

iomariani
Copy link
Contributor

Bug: Whenever the click of a VsButton happens it triggers a nextTick, but if the button does not exist anymore it will throw the error:
Cannot read property 'clientWidth' of undefined

Fix: Check if button reference still exists when nextTick happens.
Issue reference #726

*Bug:* Whenever the click of a VsButton happens it triggers a nextTick, but if the button does not exist anymore there will throw the error:
`Cannot read property 'clientWidth' of undefined`

*Fix: * Check if button reference still exists when nextTick happens.
@clopezpro
Copy link

image
Click in accept return this warn.

image

@clopezpro
Copy link

MERGUE

@clopezpro
Copy link

this code solved the problem, thanks
image

@zaza-hikayat
Copy link

when i run script
this.$vs.dialog({ type:'confirm', color: 'warning', title, text, accept:() => {callback()} })

appear error Cannot read property 'clientWidth' of undefined , and then i use this patch and error resolve,
thanks @iomariani,

please merge to master thanks

@lk77
Copy link
Contributor

lk77 commented Jan 4, 2021

Hello,

i have this issue again, it was fixed for some time, at least for me, but i did a npm update and the issue is back.

i'm using $vs.dialog which use VsButton internally

i reverted vuesax for now npm install [email protected]

this was the version i was using prior to npm update, but i don't know at which version it broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants