Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return None when str coercion fails or when empty #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return None when str coercion fails or when empty #20

wants to merge 1 commit into from

Conversation

mattmazzola
Copy link
Contributor

  • Returning None when extraction is empty prevents choosing one of the choices based on Levenshtein distance
  • Also return None on str coercion failure since returning empty string would return None later anyways, and it also seems like an incorrect extraction fallback value

Fixes #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mattmazzola