Skip to content

Commit

Permalink
disable playwright in CI for now to work around WebGL not working (mi…
Browse files Browse the repository at this point in the history
  • Loading branch information
trusktr committed Apr 28, 2024
1 parent 59ca5de commit 8f842cf
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions config/web-test-runner.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,22 @@ export default {

// Override the default Chrome launcher with Playwright launcher so to test
// in all browsers in CI.
browsers: process.env.CI
? [
playwrightLauncher({product: 'chromium'}),
browsers: undefined, // undefined -> use default Chrome launcher
// TODO restore playwright once the WebGL issue is fixed with macOS in GitHub Actions (https://github.com/microsoft/playwright/issues/30585)
// browsers: process.env.CI
// ? [
// playwrightLauncher({product: 'chromium'}),

// TODO re-enable these once we fix native.js in lowclass for
// Firefox and Safari
// playwrightLauncher({product: 'firefox'}),
// playwrightLauncher({product: 'webkit'}),
]
: // undefined defaults to the test-runner Chrome launcher (must be
// locally installed). Note, it will not work in CI unless we add a step
// that installs Chrome, so we use playwrightLauncher in CI because it
// downloads the browsers.
undefined,
// // TODO re-enable these once we fix native.js in lowclass for
// // Firefox and Safari
// // playwrightLauncher({product: 'firefox'}),
// // playwrightLauncher({product: 'webkit'}),
// ]
// : // undefined defaults to the test-runner Chrome launcher (must be
// // locally installed). Note, it will not work in CI unless we add a step
// // that installs Chrome, so we use playwrightLauncher in CI because it
// // downloads the browsers.
// undefined,

// We're using vanilla ES Modules, not automatic Node-based module
// resolution, only import maps. Yeah baby! Embrace the platform!
Expand Down

0 comments on commit 8f842cf

Please sign in to comment.