Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NUKE for build automation #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Oct 5, 2022

First of all, sorry for pushing the PR without asking. This is up to discussion and I had pretty good template to start with.

NUKE has proven to be great build system. I've used it with Quartz.NET, Spring.NET and helped to migrate to it in NSwag and NJsonSchema (I got contributor access to NSwag and NJsonSchema to make migration easier). This PR adds build capabilities that should work on Windows/Linux/MacOS. One just needs to run build.cmd or build.sh depending on the platform.

With this PR GitHub Actions templates are automatically generated and there's automatic push to NuGet when you push a new tag in format (for example) "v3.0.3", otherwise it could create a MyGet feed pre-release if you had an account there - MyGet isn't being used to it's skipped but could easily be added. So release process should be easy and automatically leaves trace in format of the tag (GitHub is great for generating release notes too nowadays).

I would be happy to push this trough if there are any rough edges and need for tweaks, I'm also quite capable of handling the "no thanks" response 馃檪 I would also be humbled if you'd consider adding me as contributor to help with release process and such chores that you might not have the time for always (contributors can have their workflow YAML executed).

@lahma
Copy link
Contributor Author

lahma commented Oct 5, 2022

Seems that the current workflows don't address PRs so can't see outcome of this build. This PR should also allow building of PRs though.

@lahma lahma force-pushed the nuke-build branch 3 times, most recently from 30b3f93 to 79e38ea Compare November 9, 2023 06:32
* NET 6.0 as test project target framework
* Upgrade to latest Fluid.Core
* Upgrade Newtonsoft.Json to non-vulnerable version
@lahma
Copy link
Contributor Author

lahma commented Nov 9, 2023

Hey @lukencode , I hope you're well. Could you please consider checking out this PR. It now also updates test projects from obsolete netcoreapp3.1 to net6.0 and fixes vulnerable package dependency.

If you need help processing the repo's PRs I'm also open to take some of the responsibilities if you grant me collaborator rights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant