Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Inline images for SmtpSender #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

austinpn
Copy link

@austinpn austinpn commented Aug 6, 2021

Changed System.Net.Mime.ContentDisposition.Inline to match Core.Models.Attachment.IsInline.
Attachment's Content-Disposition header will be set to "inline" instead of "attachment" when attachment is marked inline, allowing it to be referenced by content-id when using SmtpSender.

@wilkovanderveen
Copy link

I had this issue also. I was already fixing the branch until I saw this pull request. Please add an unit test @austinpn

@austinpn
Copy link
Author

austinpn commented Apr 28, 2022

There is not really a good way to test this without parsing the email on the other end, or exposing CreateMailMessage(IFluentEmail email) in SmtpSender. I can test that a message is sent, but that asserts to true regardless of System.Net.Mail.Attachment.ContentDisposition.Inline correctly mirroring Core.Models.Attachment.IsInline.

@wilkovanderveen
Copy link

@austinpn I added some tests to a new pull request i created. I am not very expirienced with the github way of contributing, so forgive for not adding it to your PR (if possible))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants