-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to maven and massive clean and fixup #93
Open
farmboy0
wants to merge
43
commits into
luaj:master
Choose a base branch
from
farmboy0:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmboy0
commented
Jul 23, 2021
- Converted the project to a multi module maven project.
- Tests have been converted to JUnit5 and executed during the build.
- Many test failures fixed, others disabled for now.
- Build creates a coverage report.
- Source code has been cleaned up and formatted, formatting and cleanup definition is included.
The error message is more specific with luaj
Too many failing tests that need to be fixed first
Any chance this PR will be accepted ? Does this project is still alive ? I am interested to update this project to more recent java version (like supporting java module). But I prefer to start from a clean maven version. |
For those wanting to using this as a dependency looks like it is published on jitpack.io here: https://jitpack.io/#farmboy0/luaj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.