Add IE11 support #61
Open
Add IE11 support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| emitChange(evt) { | ||
| if (!this.htmlEl) return; | ||
| var html = this.htmlEl.innerHTML; | ||
| if (this.props.onChange && html !== this.lastHtml) { | ||
| evt.target = { value: html }; | ||
| this.props.onChange(evt); |
There was a problem hiding this comment.
You might want to somehow pass the html to onChange!
There was a problem hiding this comment.
Isn't it enough to get the whole MutationRecord (=evt) in onChange? The element's innerHtml is then accessible via evt.target.innerHtml.
There was a problem hiding this comment.
Depends on the node you're getting. In my case I get a text node so evt.target.innerHTML isn't a thing. Drop document.createTextNode('') in your console to see what's there.
|
@lovasoa @notatestuser I re-added |
|
This was opened a year ago. Any chance this ever gets merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using a MutationObserver instead, solution proposed by @notatestuser (#43 (comment)).