Lor 214 list user #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciuscosmome
suggested changes
Feb 8, 2024
Co-authored-by: Cosmo <[email protected]>
Co-authored-by: Cosmo <[email protected]>
Co-authored-by: Cosmo <[email protected]>
Co-authored-by: Cosmo <[email protected]>
Co-authored-by: Cosmo <[email protected]>
viniciuscosmome
suggested changes
Feb 20, 2024
Comment on lines
36
to
37
| export type GetCredential = Pick<Credential, 'id' | 'email'> & { | ||
| parentProfile: Pick<ParentProfile, 'id' | 'fullname'> & { |
There was a problem hiding this comment.
Não retornar id da credencial, nem do responsável. esse id é obtido pela chave de acesso
Suggested change
| export type GetCredential = Pick<Credential, 'id' | 'email'> & { | |
| parentProfile: Pick<ParentProfile, 'id' | 'fullname'> & { | |
| export type GetCredential = Pick<Credential, 'email'> & { | |
| parentProfile: Pick<ParentProfile, 'fullname'> & { |
| @@ -81,6 +80,37 @@ export class AccountRepository { | |||
| return response; | |||
| } | |||
|
|
|||
| async getCredentialId(id: string): Promise<GetCredential | void> { | |||
| const response = await this.prisma.credential | |||
| .findFirst({ | |||
There was a problem hiding this comment.
O método findFirst passa por todos os dados da tabela para buscar o primeiro que aparece, já o findUnique usa o índice criado por ser um dado único.
Suggested change
| .findFirst({ | |
| .findUnique({ |
Comment on lines
87
to
99
| select: { | ||
| id: true, | ||
| email: true, | ||
| parentProfile: { | ||
| select: { | ||
| id: true, | ||
| fullname: true, | ||
| childrens: { | ||
| select: { | ||
| id: true, | ||
| fullname: true, | ||
| gender: true, | ||
| birthdate: true, |
There was a problem hiding this comment.
remover id da credencial, id do responsável
requisitos de aceiteAdicionar um ponto de acesso para ler todas as informações do usuário
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint GET account to list parent and childrens data.
Output will be like this:
{
"message": "Dados recebidos com sucesso",
"data": {
"credential": {
"id": "3",
"email": "09e5c489a25959dfea369ac0b98976f074cff9baae99e0ffa34c442c713c6b91",
"parentProfile": {
"id": "2a531e67-2a99-4c38-a873-fb434fbe9d43",
"fullname": "Daiane Bolzan",
"childrens": [
{
"id": 2,
"fullname": "Joana Bolzan",
"gender": "female",
"birthdate": "2000-09-09T00:00:00.000Z"
} ] } }}}