feat: add check to verify if task belong to child

loryblu · May 9, 2024 · ac9998f · ac9998f
1 parent 7a7241e
commit ac9998f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/src/modules/task/task.controller.ts b/src/modules/task/task.controller.ts
@@ -127,6 +127,7 @@ export class TaskController {
  await this.service.deleteTask({
  id: id,
  parentId: sessionInfo.pid,
+ childrenId: sessionInfo.cid,
  });
 
  return {

diff --git a/src/modules/task/task.entity.d.ts b/src/modules/task/task.entity.d.ts
@@ -45,4 +45,5 @@ export type iTaskRepositoryUpadateInput = {
 export type iTaskRepositoryDeleteTaskInput = {
  id: string;
  parentId: string;
+ childrenId: string;
 };
diff --git a/src/modules/task/task.repository.ts b/src/modules/task/task.repository.ts
@@ -102,10 +102,11 @@ export class TaskRepository {
  .catch((error) => handleErrors(error));
  }
 
- async findTaskById(id: number) {
+ async findTaskByIdAndChildren(id: number, childrenId: number) {
  return await this.prisma.task.findFirst({
  where: {
  id,
+ childrenId,
  },
  });
  }

diff --git a/src/modules/task/task.service.ts b/src/modules/task/task.service.ts
@@ -44,9 +44,13 @@ export class TaskService {
  }
 
  async deleteTask(input: iTaskRepositoryDeleteTaskInput) {
- const idNumber = parseInt(input.id);
+ const taskId = parseInt(input.id);
+ const childrenId = parseInt(input.childrenId);
 
- const existingTask = await this.repository.findTaskById(idNumber);
+ const existingTask = await this.repository.findTaskByIdAndChildren(
+ taskId,
+ childrenId,
+ );
  const parent = await this.repository.validateParent(input.parentId);
 
  if (!existingTask) {
@@ -60,7 +64,7 @@ export class TaskService {
  );
  }
 
- await this.repository.deleteTask(idNumber);
+ await this.repository.deleteTask(taskId);
  }
 
  private processTasks(