Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OSError: [Errno 22] Invalid argument error for book ID #276

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

holzkohlengrill
Copy link

Fixes the error:

Traceback (most recent call last):
  File "C:\1-repos\safaribooks\safaribooks.py", line 1112, in <module>
    SafariBooks(args_parsed)
  File "C:\1-repos\safaribooks\safaribooks.py", line 314, in __init__
    self.display = Display("info_%s.log" % escape(args.bookid))
  File "C:\1-repos\safaribooks\safaribooks.py", line 57, in __init__
    logs_handler = logging.FileHandler(filename=self.log_file)
  File "C:\Program Files\Python39\lib\logging\__init__.py", line 1142, in __init__
    StreamHandler.__init__(self, self._open())
  File "C:\Program Files\Python39\lib\logging\__init__.py", line 1171, in _open
    return open(self.baseFilename, self.mode, encoding=self.encoding,
OSError: [Errno 22] Invalid argument: 'C:\\1-repos\\safaribooks\\info_https:\\www.safaribooksonline.com\library\view\test-driven-development-with\9781491958698\\.log'

@holzkohlengrill
Copy link
Author

@cvieiraneto anything open before we can merge?

Copy link
Owner

@lorenzodifuccia lorenzodifuccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @holzkohlengrill, thank you for the PR.
Could you please see the comment on the changed file?

safaribooks.py Show resolved Hide resolved
@holzkohlengrill
Copy link
Author

holzkohlengrill commented May 30, 2023

@lorenzodifuccia / @cvieiraneto anything pending so that we can merge?

@holzkohlengrill
Copy link
Author

@lorenzodifuccia / @cvieiraneto can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants