allow users to define a default priorityClass #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
johannesfrey
requested changes
May 14, 2024
narcis96
force-pushed
the
narcis/fix_1718
branch
4 times, most recently
from
88f4caa
to
d85b00a
Compare
| @@ -535,6 +535,10 @@ | |||
| "overwriteManifests": { | |||
| "type": "string", | |||
| "description": "OverwriteManifests can be used to overwrite the coredns manifests used to deploy coredns" | |||
| }, | |||
| "priorityClassName": { | |||
There was a problem hiding this comment.
I guess this also must find its way into the docs: https://github.com/loft-sh/vcluster-docs/tree/main/docs/_partials/config/controlPlane/coredns
There is gen-partials.sh which updates this. Might be that this done for the next beta release anyway though?! (cc @aimeeu)
There was a problem hiding this comment.
The process is manual and yes, we generate new partials for each release.
There was a problem hiding this comment.
so we should do it in another MR, right ?
Co-authored-by: Johannes Frey <[email protected]>
|
|
@narcis96 we should not have |
FabianKramm
requested changes
May 16, 2024
Co-authored-by: Johannes Frey <[email protected]>
johannesfrey
approved these changes
May 16, 2024
Co-authored-by: Johannes Frey <[email protected]>
FabianKramm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1718
Ref ENG-3563