Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binaries volume config #1581

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matskiv
Copy link
Contributor

@matskiv matskiv commented Mar 4, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
There are cases where an emptyDir volume of sufficient size can not be provided, so users should be allowed to override the /binaries volume with an alternative.
Additionally, current ephemeral storage requests are no sufficient for some distros:

k0s
# du -h /binaries/*
203.2M	/binaries/k0s

k8s
# du -h /binaries/*
108.3M	/binaries/kube-apiserver
100.9M	/binaries/kube-controller-manager
69.4M	/binaries/vcluster

eks
# du -h /binaries/*
105.8M	/binaries/kube-apiserver
98.4M	/binaries/kube-controller-manager
69.4M	/binaries/vcluster

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would request too little ephemeral storage.
Added .syncer.storage.binariesVolume helm chart value to allow overriding /binaries volume.

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit 575bf96
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/65e79b5ad827820008e95b85

charts/eks/templates/syncer.yaml Outdated Show resolved Hide resolved
charts/eks/values.yaml Outdated Show resolved Hide resolved
@facchettos
Copy link
Contributor

What is the scenario which would prevent us from using emptyDir ? I think we should hold off on adding more options if we are not sure they'd be useful

@matskiv matskiv force-pushed the improve-binaries-volume-config branch from 96ab05e to b7707ba Compare March 5, 2024 22:19
@matskiv matskiv force-pushed the improve-binaries-volume-config branch from b7707ba to 575bf96 Compare March 5, 2024 22:23
@matskiv
Copy link
Contributor Author

matskiv commented Mar 5, 2024

What is the scenario which would prevent us from using emptyDir ? I think we should hold off on adding more options if we are not sure they'd be useful

Some clusters have strict limits for the emptyDir size, and in such cases a different type of volume will have to be used.

As for the failing test, I'll figure it out tomorrow. But after a quick check - seems I need to update structs in the loft-sh/vcluster-values, but this is not documented as far as I can see(nothing in the CONTRIBUTING.md or the test case code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants