Removing eval (function constructor) #5863
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many linters complains about evals, so removing the legacy
Function('return this')()
will greatly help!What about compatibility?
The existing
globalThis
has a great support for 5 years now, including Node 12, Deno 1.0, Safari 12.1, Chrome 71, Firefox 65: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#browser_compatibilityThis issue has been reported many times in this and many other repositories:
https://github.com/lodash/lodash/issues?q=eval
most recent: #5862