update ASF APIs, switch SQS to JSON again #10741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localstack-bot
added
area: asf
area: dependencies
localstack-bot
added
the
semver: patch
localstack-bot
requested review from
MEPalma,
thrau,
baermat,
viren-nadkarni and
macnev2013
as code owners
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 33m 28s ⏱️ + 1m 48s Results for commit cc358d3. ± Comparison against base commit 0da9865. This pull request removes 127 and adds 127 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 6 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 2m 57s ⏱️ Results for commit cc358d3. ♻️ This comment has been updated with latest results. |
localstack-bot
requested review from
bentsku,
joe4dev and
dfangl
as code owners
|
This PR contains a bump of |
alexrashed
force-pushed
the
asf-auto-updates
branch
from
4494f1a
to
8a5b52e
Compare
Comment on lines
+1598
to
+1602
| @handler("ValidateStateMachineDefinition", expand=False) | ||
| def validate_state_machine_definition( | ||
| self, context: RequestContext, request: ValidateStateMachineDefinitionInput, **kwargs | ||
| ) -> ValidateStateMachineDefinitionOutput: | ||
| raise NotImplementedError |
alexrashed
force-pushed
the
asf-auto-updates
branch
from
8a5b52e
to
72b0c10
Compare
|
FYI: Converted this PR to draft since a downstream pipeline failed on these changes. |
alexrashed
force-pushed
the
asf-auto-updates
branch
from
72b0c10
to
010f449
Compare
alexrashed
added
semver: minor
alexrashed
force-pushed
the
asf-auto-updates
branch
from
010f449
to
52dc5d3
Compare
alexrashed
force-pushed
the
asf-auto-updates
branch
from
52dc5d3
to
cc358d3
Compare
bentsku
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM! Quite an extensive change again, but hoping this is the last time we have to do the switch! Thanks a lot for taking care of it once again.
I just have a comment regarding a change to an SNS test where we use sns_query, not too sure if that was necessary or a typo?
Other than that, the pipeline being green gives us the confidence 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 ASF Update Report 🚀
This PR has been automatically generated to update the generated API stubs for our ASF services.
It uses the latest code-generator from the master branch (scaffold.py) and the latest published version of botocore to re-generate all API stubs which are already present in the
localstack.aws.apimodule of the master branch.🔄 Updated Services
This PR updates the following services:
👷🏽 Handle this PR
The following options describe how to interact with this PR / the auto-update:
✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.
🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.
✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.
⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.