implement SNS Filter/operators $or, suffix, equals-ignore-case, anything-but #10691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:sns
1 task
Co-authored-by: Mathieu Cloutier <[email protected]>
bentsku
changed the title
cloutierMat
approved these changes
May 16, 2024
|
|
||
| return any( | ||
| all( | ||
| any( |
There was a problem hiding this comment.
🤣 Ok, I understand why you want to keep it separate from the attributes policy...
| filter_policy = {"key": [{"anything-but": {"suffix": "test"}}]} | ||
| _subscribe(filter_policy) | ||
| self._add_normalized_field_to_snapshot(e.value.response) | ||
| snapshot.match("error-condition-anything-but-suffix", e.value.response) |
There was a problem hiding this comment.
Nice! I kept wondering if this was a thing we needed to add support for! ⚡
There was a problem hiding this comment.
yeah me too, I thought the documentation was lying... but no, they really do not support anything else than prefix 😆
Thanks @cloutierMat, it's actually heavily inspired by yours 🚀 you definitely fixed all the recursion of SNS! Thank you so much 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #9738, AWS launched new operators for SNS filtering.
suffixandequals-ignore-caseare pretty simple to implement, but$ornecessitated a quite consequent rewrite, as the logic can get quite convoluted pretty fast. It quickly creates a lot of different forks, where one rule can have multiple branches and a payload can have multiple branches too if it contains array.Also included better support for
anything-but, which can accept any regular "plain" values like string, numbers and list of string & number. It can also accept theprefixoperator, see https://docs.aws.amazon.com/sns/latest/dg/string-value-matching.html#string-anything-but-matching-prefixAlso, we still had an issue with some ordering of complex payload with arrays, see #10567 (comment)
Changes
flatten_policy, thanks a lot @cloutierMat for the great pairing session we've had, and you providing the final solution fixing all our issues! 🥳suffixandequals-ignore-caseanything-butskipfor the AWS validated$ortestflatten_payloadfixes #10567, fixes #9738