[SFN] Fix Unknown Service sfn errors #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
joe4dev
approved these changes
Apr 10, 2024
|
|
||
| class StateTaskServiceAwsSdk(StateTaskServiceCallback): | ||
| _NORMALISED_SERVICE_NAMES = {"dynamodb": "DynamoDb"} | ||
| # Defines bindings of lower-cased service names to the StepFunctions service name included in error messages. | ||
| _SERVICE_ERROR_NAMES = {"dynamodb": "DynamoDb", "sfn": "Sfn"} |
| @@ -139,6 +139,63 @@ def test_dynamodb_put_update_get_item( | |||
| exec_input, | |||
| ) | |||
|
|
|||
| @markers.snapshot.skip_snapshot_verify( | |||
| paths=[ | |||
| # TODO: aws-sdk SFN integration now appears to be inserting decorated error names into the cause messages. | |||
There was a problem hiding this comment.
nice explaining comments about what are the next steps to fix this 🏅
| ] | ||
| ) | ||
| @markers.aws.validated | ||
| def test_sfn_send_task_success_no_such_token( |
There was a problem hiding this comment.
success and failure could be two parameters of a parametrized test with identical code. See parametrization comment in #10168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current version of the SFN v2 interpreter lacks the capability to enhance aws-sdk failures if the service name of the resource isn't associated with any explicit bindings or isn't available in boto's service catalog. As a result, it generates unknown service error messages, causing the interpreter to fail without reporting the decorated aws-sdk source error.
This pull request aims to resolve this issue by refining the logic for decorating service error names to accurately search for a normalised error name. In cases where none is found, it logs such incidents and returns the original service name as an error. This adjustment is intended to enable the computation to continue, albeit with slightly different cause and error string formatting, while also emphasising the necessity for more explicit normalised error name bindings.
Furthermore, the PR includes bindings for aws-sdk stepfunctions error names along with relevant snapshot tests, addressing issue #10622.
Changes