Stop hard-coding 'http' protocol for sync server interactions in AuthProvider.ts #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbCaudill
requested changes
May 20, 2024
bigdogwillfeed
force-pushed
the
fix-hardcoded-http
branch
from
98fb3e6
to
d047a00
Compare
http is great for local development and tests but we want secure connections everywhere else
Rather than get better at guessing, default to the old behavior of assuming http unless we're told otherwise.
HerbCaudill
force-pushed
the
fix-hardcoded-http
branch
from
d047a00
to
811fcc8
Compare
since this is a pure function (not dependent on any class members) it doesn't need to be a method on the class, can just be a stand-alone utility function
|
Looks good. I've changed Also this way it can be easily tested in isolation - I've added a couple of simple tests for the heck of it. |
HerbCaudill
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves
We're unable to properly connect to sync servers hosted with TLS because the
AuthProvideris always trying to make certain requests usinghttp://.Description
I've added a private method in
AuthProvider.tsto determine which protocol to use based on the given server url we're working with. In this case I'm making a simple check that returns "http" if the url contains "localhost" and otherwise defaults to "https".