update dockerfile #2663
update dockerfile #2663
Conversation
There was a problem hiding this comment.
Hmm this will remove the possibilty of caching in CI I asusme? (As the updated content in local-builder won't be synced into litentry/litentry-worker:base
There was a problem hiding this comment.
In my understanding, litentry/litentry-worker:base only provides the runtime environment for the worker and adapts the entrypoint script. When building a new image, it's only necessary to update the binary files within it.
There was a problem hiding this comment.
It's more than that => for CI builds (dev-build) it's responsible to update the cache to accelerate the build too.
In production (release) build I agree we should do a clean build without caching
| @@ -21,7 +21,7 @@ RUN cargo build --locked --profile $PROFILE $BUILD_ARGS | |||
| # ========================== | |||
| # stage 2: packaging | |||
| # ========================== | |||
| FROM ubuntu:20.04 | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
We can update this only when our production parachain nodes are all deployed with docker.
|
I'll close it for now - it's superseded by #2733 |
Context
Modify the Dockerfile to adapt for deploying tee-worker and parachain using Docker.
Labels
Please apply following PR-related labels when appropriate:
C1-noteworthyHow (Optional)
The Docker build for tee-worker is based on the worker's base image. For a new build, only the binary needs to be updated.
The base image for parachain has been changed to ubuntu:22.04.
Testing Evidences
Now it's running on tee-staging.