Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Swiss flag to official size #1244

Closed
wants to merge 1 commit into from
Closed

Conversation

javiergarmon
Copy link

@javiergarmon javiergarmon commented May 9, 2024

The Swiss flag must be a square as it's described in the official documentation: https://www.fedlex.admin.ch/eli/cc/2015/613/en#art_3

To preserve the proportions of the 4x3 flag, the file has the same size as before, but the flag is squared surrounded by transparent space.

Screenshot 2024-05-09 at 13 46 55

@NotTsunami
Copy link
Collaborator

I'm a little hesitant to merge something like this because all 4x3 flags are intentionally designed to be displayed at 4x3 resolution, despite their flag's own ratio.

@javiergarmon
Copy link
Author

javiergarmon commented May 9, 2024

@NotTsunami, I understand the problem. That's why I provided a solution that I believe is crucial and involves having a squared flag file and not the wrong one. Your expertise in implementing this solution is highly valued.

The current problem is:

We have a similar situation with Nepal (NP) flag. You are using the actual flag and displaying a transparent space on its right side. I can modify the PR to do the same if you want.

@S1r-Lanzelot
Copy link

I believe, if the maintainers would like to support native flags, it would be best to create a flags/native directory and add all the proper flags by native ratio there. The issue of incorrect ratios is common amongst many flags in the 1x1 and 4x3 directories and not isolated to the Swiss flag.

It is an interesting case with the flag of Nepal, I am not sure the appropiate approach. However, if we believe we should pad the flags to maintain flag aspect ratios, then we should do the same with, for example, the flag of Germany: it would be scaled to fit width wise within the 4x3 viewport, having white space above/below it.

I would assume people enjoy using this library because it standardizes the ratios/dimensions across all flags despite it being different than the flag specifications. If a native ratio is needed then I think https://github.com/hampusborgos/country-flags has a good collection.

@javiergarmon
Copy link
Author

What should I do? Close the PR or make any changes in the file?

@lipis
Copy link
Owner

lipis commented May 21, 2024

I'm sorry but this won't happen!

@lipis lipis closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants