Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(owlgen): false prefix on class uri #1375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Silvanoc
Copy link
Contributor

The default prefix is being used for classes where "class_uri" is providing a different prefix. This patch fixes this issue.

Following schema

id: https://example.org/my-schema
prefixes:
  linkml: https://w3id.org/linkml/
  rdl: https://rds.posccaesar.org/ontology/lis14/rdl/
imports:
  - linkml:types
default_range: string

classes:
  MySubclass:
    is_a: FunctionalObject
  FunctionalObject:
    class_uri: rdl:FunctionalObject

Results in an OWL file with following entry

[...]

<https://example.org/my-schema/MySubclass> a owl:Class,
        linkml:ClassDefinition ;
    rdfs:label "MySubclass" ;
    rdfs:subClassOf <https://example.org/my-schema/FunctionalObject> .

[...]

Please notice that instead of <https://example.org/my-schema/FunctionalObject> it should say rdl:FunctionalObject. This PR tries to fix this issue.

@Silvanoc
Copy link
Contributor Author

Silvanoc commented Mar 30, 2023

Please notice that I'm simply applying to _class_uri the same logic being used in _prop_uri that provides the expected result for slots.

@Silvanoc Silvanoc force-pushed the fix-wrong-prefix-on-class-uri branch from 1d2282b to ffd9d49 Compare May 16, 2023 11:33
@Silvanoc Silvanoc force-pushed the fix-wrong-prefix-on-class-uri branch from ffd9d49 to 5b580e5 Compare November 17, 2023 07:08
The default prefix is being used for classes where "class_uri" is
providing a different prefix. This patch fixes this issue.

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
@Silvanoc Silvanoc force-pushed the fix-wrong-prefix-on-class-uri branch from 5b580e5 to f3ad7e5 Compare November 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant