Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #5694

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix flaky tests #5694

merged 2 commits into from
May 24, 2024

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented May 23, 2024

Close #5681
Close #4553

@@ -160,6 +162,7 @@ void writeAfterStreamClosed() throws InterruptedException {
if (i < 2) {
os.write(i);
Copy link
Member Author

@minwoox minwoox May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.write() was raising an exception after .then(byteStreamMessage::abort) was called.

@minwoox minwoox added this to the 1.29.0 milestone May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (14c5566) to head (1e7082f).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5694      +/-   ##
============================================
+ Coverage     74.05%   74.12%   +0.07%     
- Complexity    21253    21325      +72     
============================================
  Files          1850     1855       +5     
  Lines         78600    78812     +212     
  Branches      10032    10066      +34     
============================================
+ Hits          58209    58422     +213     
+ Misses        15686    15668      -18     
- Partials       4705     4722      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minwoox minwoox merged commit 2414099 into line:main May 24, 2024
17 checks passed
@minwoox minwoox deleted the fix_flaky branch May 24, 2024 04:21
Dogacel pushed a commit to Dogacel/armeria that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants