Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to automatically delete multipart temporary files #5653

Merged
merged 10 commits into from
May 30, 2024

Commits on Apr 30, 2024

  1. Provide a way to automatically delete multipart temporary files

    Motivation:
    
    Armeria does not automatically delete the uploaded files, so users
    should manually remove the temporary files themselves.
    It would be useful if we provided some options for how to delete
    multipart temporary files.
    
    Related: line#5652
    
    Modifications:
    
    - Add `MultipartRemovalStrategy` that is used to determine how to delete
      multipart files. For now, three options are supported.
      - NEVER
      - ON_RESPONSE_COMPLETION
      - ON_JVM_SHUTDOWN
    - Add builder methods to server/virtualhost/service builders.
    
    Breaking changes:
    
    - Multipart temporary files are now automatically removed when a
    response is fully sent. If you want to keep the existing behavior,
    use `MultipartRemovalStrategy.NEVER.
    
    Result:
    
    You can now specify when to remove multipart temporary files using
    `MultipartRemovalStrategy`.
    
    ```java
    Server
      .builder()
      .multipartRemovalStrategy(MultipartRemovalStrategy.ON_RESPONSE_COMPLETION)
    ```
    ikhoon committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    330402c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Remove ON_JVM_SHUTDOWN option

    ikhoon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4dc1fa2 View commit details
    Browse the repository at this point in the history
  2. fix compile error

    ikhoon committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b75c256 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    feaeb6c View commit details
    Browse the repository at this point in the history
  2. getter for VirtualHost

    ikhoon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    005d22e View commit details
    Browse the repository at this point in the history
  3. addres comments by @trustin

    ikhoon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    25b2189 View commit details
    Browse the repository at this point in the history
  4. clean up

    ikhoon committed May 7, 2024
    Configuration menu
    Copy the full SHA
    37d78bd View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fix errors

    ikhoon committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f8cac35 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    20c37c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec4abe2 View commit details
    Browse the repository at this point in the history