Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add human-readable short channel ID #8676

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add human-readable short channel ID #8676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0569d3
feature #8650
andiz2 Apr 22, 2024
217dfc6
updated to pointer
andiz2 Apr 22, 2024
4dc2408
updated to pointer
andiz2 Apr 22, 2024
b39f73f
updated to pointer
andiz2 Apr 22, 2024
837e65b
update shortchannelidX
andiz2 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions lnrpc/lightning.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions lnwire/short_channel_id.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ func (c ShortChannelID) String() string {
return fmt.Sprintf("%d:%d:%d", c.BlockHeight, c.TxIndex, c.TxPosition)
}

// String generates a human-readable representation of the channel ID with 'x' instead of ':'.
func (c ShortChannelID) StringX() string {
return fmt.Sprintf("%dx%dx%d", c.BlockHeight, c.TxIndex, c.TxPosition)
}

// Record returns a TLV record that can be used to encode/decode a
// ShortChannelID to/from a TLV stream.
func (c *ShortChannelID) Record() tlv.Record {
Expand Down
1 change: 1 addition & 0 deletions rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4405,6 +4405,7 @@ func createRPCOpenChannel(r *rpcServer, dbChannel *channeldb.OpenChannel,
RemotePubkey: nodeID,
ChannelPoint: chanPoint.String(),
ChanId: dbScid.ToUint64(),
ShortChannelIdStringX: dbScid.StringX(),
Capacity: int64(dbChannel.Capacity),
LocalBalance: int64(localBalance.ToSatoshis()),
RemoteBalance: int64(remoteBalance.ToSatoshis()),
Expand Down