[3/5]: multi: add new AuxFundingController for custom external funding flows #8622
+1,036
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
added
funding
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Pull reviewers statsStats of the last 30 days for lnd:
|
ffranr
reviewed
Apr 5, 2024
guggero
reviewed
Apr 9, 2024
Roasbeef
commented
Apr 16, 2024
|
Pushed a few new commits: we'll now include the taproot internal key in the PBST template we return for the PSBT funding flow. |
guggero
force-pushed
the
aux-leaf-fetcher
branch
3 times, most recently
from
a8bfe36
to
e04f50d
Compare
guggero
force-pushed
the
aux-leaf-fetcher
branch
from
e04f50d
to
9f4677d
Compare
1 task
guggero
changed the title
This was referenced Apr 24, 2024
guggero
force-pushed
the
aux-leaf-fetcher
branch
from
9f4677d
to
4969b5a
Compare
guggero
force-pushed
the
aux-leaf-fetcher
branch
from
4969b5a
to
5baf204
Compare
guggero
force-pushed
the
aux-leaf-fetcher
branch
from
5baf204
to
11f3626
Compare
guggero
force-pushed
the
aux-leaf-fetcher
branch
3 times, most recently
from
3fb4bb6
to
72f7b80
Compare
|
@Roasbeef, remember to re-request review from reviewers when ready |
3 tasks
guggero
reviewed
May 16, 2024
| binary.LittleEndian.PutUint64(nonce[:], f.chanIDNonce) | ||
| f.chanIDNonce++ | ||
| f.nonceMtx.Unlock() | ||
| nextNonce := f.chanIDNonce.Add(1) |
There was a problem hiding this comment.
As described in the commit message, we change the algorithm here. Do these values need to be in sync between node implementations/peers? Or is this value only ever used locally? Just trying to understand if this has any impact or not.
In this commit, we add a new abstract message router. Over time, the goal is that this message router replaces the logic we currently have in the readHandler (the giant switch for each message). With this new abstraction, can reduce the responsibilities of the readHandler to *just* reading messages off the wire and handing them off to the msg router. The readHandler no longer needs to know *where* the messages should go, or how they should be dispatched. This will be used in tandem with the new `protofsm` module in an upcoming PR implementing the new rbf-coop close.
Over time with this, we should be able to significantly reduce the size of the peer.Brontide struct as we only need all those deps as the peer needs to recognize and handle each incoming wire message itself.
With this commit, we allow the `MsgRouter` to be available in the `ImplementationCfg`. With this, programs outside of lnd itself are able to now hook into the message processing flow to direct handle custom messages, and even normal wire messages.
This'll be useful for new interface definitions that use the contents of the package.
This lets us get rid of the mutex usage there. We also shift the algo slightly to increment by 1, then use that as the next value, which plays nicer with the atomics.
This struct will house all the information we'll need to do a class of custom channels that relies primarily on adding additional items to the tapscript root of the HTLC/commitment/funding outputs.
With this commit, we'll now populate all the custom channel information within the OpenChannel and ChannelCommitment structs.
In this commit, we make a new `AuxFundingController` interface capable of processing messages off the wire. In addition, we can use it to abstract away details w.r.t how we obtain a `AuxFundingDesc` for a given channel. We'll now use this whenever we get a channel funding request, to make sure we pass along the custom state that a channel may require.
If this is a taproot channel, then we'll return the internal key which'll be useful to callers.
We also add a new assertion to the itests to ensure the field is being properly set.
In this commit, we modify the aux funding work flow slightly. We won't be able to generate the full AuxFundingDesc until both sides has sent+received funding params. So we'll now only attempt to bind the tapscript root as soon as we send+recv the open_channel message. We'll now also make sure that we pass the tapscript root all the way down into the musig2 session creation.
For the initiator, once we get the signal that the PSBT has been finalized, we'll call into the aux funder to get the funding desc. For the responder, once we receive the funding_created message, we'll do the same. We now also have local+remote aux leaves for the commitment transaction.
guggero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8684.
In this commit, we add the
AuxFundingControllerinterface that can be used to implement a class of custom funding channels that only requires some additional data to be inserted into the tapscript leaves for the funding/HTLC/commitment outputs. This controller also implements theMsgEndpointinterface (see #8520) as well. This allows the controller to intercept certain custom messages related to the funding process (think extra sigs for a channel factory), and even the existing funding messages.We then create a new top level config entry for this interface. This allows an external program to instantiate a
AuxFundingController, make aMsgRouter, register that, then pass both into the lnd top level config.We also pick up where the prior PR in this series left of by using the new abstraction to map a pending chan ID (kinda like the
FundingStateStepRPC) to the aux funding data. This data is then used to populate all the new custom blobs that we'll store for these new channel types, which impacts the way we construct the funding output, and also the commitment/HTLC outputs+scripts.Link to all PRs in the saga: