This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Adding lncli access to Settings tab #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the ability to see the command you sent on the logs and I've added a timestamp.
|
diofeher
changed the title
diofeher
changed the title
|
@bryanvu anything missing to merge this? |
|
@diofeher, huge apologies for the slow response on this. Am just recovering from the holidays and work on a couple other projects. I just pulled this and built it (npm run package-electron), and when I enter anything in the "lncli" text box, I'm not getting any additional output in the console. I tried "getinfo" and "help". However, when I run in dev mode (npm start), it does work. Any thoughts on why it doesn't work with the packaged version? |
|
@bryanvu I need one favor, to add lncli binaries to windows and linux :) |
|
@tanx any reason to close it? |
|
@diofeher sorry I don’t even remember closing this. |
tanx
force-pushed
the
master
branch
3 times, most recently
from
2bd846b
to
a59da11
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #54
This pull request is to see if I'm heading to the right direction. The interface should be used to interact only with lncli?
What about creating a separate tab on the left menu to interact with the CLI (separating from settings, doesn't make sense to put it there, or at least rename Settings to "Advanced Use").