Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle fallible per commitment point in channel establishment #3109

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Handle fallible per commitment point in channel establishment #3109

wants to merge 22 commits into from
+496 −228

Commits on Jun 18, 2024

  1. Async signing test util follow ups 

    - Remove unused unavailable signers in TestKeysInterface
- Remove unnecessary display implementation for SignerOp
- Move set of test disabled signer ops to EnforcementState
    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    f49df83 View commit details
    Browse the repository at this point in the history

  2. Move clearing signer funding signed flag to signer_unblocked 

    This makes things more consistent with the overall style we use for
async signing. We try to generate a signature for a message, if it's not
there, we set a pending flag, and only in `signer_unblocked` we clear
the flag and retry the signature/message.
    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cbb4a9e View commit details
    Browse the repository at this point in the history

  3. Move clearing signer commitment flag to signer_unblocked

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3f840f2 View commit details
    Browse the repository at this point in the history

  4. Clear signer pending funding created flag

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    df10ff4 View commit details
    Browse the repository at this point in the history

  5. Add logger as parameter in creating ChannelContext

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3e1cae5 View commit details
    Browse the repository at this point in the history

  6. Add HolderCommitmentPoint::Uninitialized

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cb9ba76 View commit details
    Browse the repository at this point in the history

  7. f - improve holder commitment docs

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6013f0d View commit details
    Browse the repository at this point in the history

  8. f - fix debug assertion

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3d2f215 View commit details
    Browse the repository at this point in the history

  9. Split HolderCommitmentPoint::advance off into separate function

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0c130d9 View commit details
    Browse the repository at this point in the history

  10. Return an error if we fail to advance our commitment number

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4494d96 View commit details
    Browse the repository at this point in the history

  11. Change get_per_commitment_point to return result type 

    Includes simple changes to test util signers and tests, as well as
handling the error case for get_per_commitment_point in
HolderCommitmentPoint. This leaves an `.expect("TODO")` in places
that will be addressed in upcoming commits.
    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    3c82bb5 View commit details
    Browse the repository at this point in the history

  12. Handle fallible commitment point when getting open_channel message

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a4eb312 View commit details
    Browse the repository at this point in the history

  13. Handle sending open_channel when signer is unblocked

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1a76f82 View commit details
    Browse the repository at this point in the history

  14. f - try_resolve_pending

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    41e4139 View commit details
    Browse the repository at this point in the history

  15. Handle fallible commitment point when getting accept_channel

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1e9a36f View commit details
    Browse the repository at this point in the history

  16. Handle sending accept_channel when signer is unblocked

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    84f4ff3 View commit details
    Browse the repository at this point in the history

  17. f - try_resolve_pending

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    02b9f00 View commit details
    Browse the repository at this point in the history

  18. Handle fallible commitment point when getting channel_ready

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7bf5c62 View commit details
    Browse the repository at this point in the history

  19. Handle sending channel_ready when commitment point is unblocked

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ccbe92d View commit details
    Browse the repository at this point in the history

  20. f - try_resolve_pending

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    db9f2e6 View commit details
    Browse the repository at this point in the history

  21. Add test for async open and accept channel

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    68f1d8a View commit details
    Browse the repository at this point in the history

  22. f - test unblocking signer ops in different orders for various tests

    @alecchendev
    alecchendev committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b798ffa View commit details
    Browse the repository at this point in the history