Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make codecov only run on Python3.10 #1545

Merged
merged 7 commits into from
May 22, 2024
Merged

Make codecov only run on Python3.10 #1545

merged 7 commits into from
May 22, 2024

Conversation

IgorSusmelj
Copy link
Contributor

Changes

  • Updates CI to only run codecov part for Python 3.10

MalteEbner
MalteEbner approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM^2

.github/workflows/test.yml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (8878b5b) to head (f072f28).

❗ Current head f072f28 differs from pull request most recent head ad91aeb

Please upload reports for the commit ad91aeb to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
- Coverage   82.23%   81.89%   -0.35%     
==========================================
  Files         144      144              
  Lines        6124     6119       -5     
==========================================
- Hits         5036     5011      -25     
- Misses       1088     1108      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorSusmelj IgorSusmelj requested a review from guarin May 22, 2024 07:14
@IgorSusmelj IgorSusmelj mentioned this pull request May 22, 2024
Open
@IgorSusmelj IgorSusmelj enabled auto-merge (squash) May 22, 2024 09:33
@IgorSusmelj IgorSusmelj merged commit 8fc3a2e into master May 22, 2024
8 checks passed
@IgorSusmelj IgorSusmelj deleted the ensure-codecov-only-runs-on-python310-igor branch May 22, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarin guarin guarin approved these changes

@MalteEbner MalteEbner Awaiting requested review from MalteEbner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IgorSusmelj @MalteEbner @guarin