Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input and lightly mount #1537

Merged

Conversation

guarin
Copy link
Contributor

@guarin guarin commented May 10, 2024

Changes

  • Validate input and lightly mount

This gives the user better feedback whether the input and lightly mounts were correctly passed to lightly-serve

How was it tested?

  • Added unit tests
  • Ran manual tests

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (90c5d9f) to head (4efa35e).

Files Patch % Lines
lightly/cli/serve_cli.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.01%     
==========================================
  Files         144      144              
  Lines        6073     6116      +43     
==========================================
+ Hits         4992     5028      +36     
- Misses       1081     1088       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@japrescott japrescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing! Thanks! Just one UX question with the error msgs but already approved for you to make the decision

lightly/api/serve.py Outdated Show resolved Hide resolved
@guarin guarin enabled auto-merge (squash) May 13, 2024 11:08
@guarin guarin disabled auto-merge May 13, 2024 12:14
@guarin guarin enabled auto-merge (squash) May 13, 2024 12:14
@guarin guarin disabled auto-merge May 15, 2024 11:08
@guarin guarin enabled auto-merge (squash) May 15, 2024 11:08
@guarin guarin merged commit 3484416 into master May 15, 2024
9 of 10 checks passed
@guarin guarin deleted the guarin-lig-4837-lightly-serve-input-directory-sanity-check branch May 15, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants