Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lazy loading from dashboard tiles #10102

Merged
merged 1 commit into from
May 20, 2024

Conversation

joaoviana
Copy link
Contributor

Reverts changes added in: #7876

Description:

Removes feature flag check for lazy-load-dashboard-tiles.
Removes lazy loading from dashboard tiles

Re-ran a dashboard and all is OK

Reviewer actions

  • I have manually tested the changes in the preview environment
  • I have reviewed the code
  • I understand that "request changes" will block this PR from merging

@joaoviana joaoviana requested a review from ZeRego May 17, 2024 09:13
@joaoviana joaoviana self-assigned this May 17, 2024
@owlas owlas requested a deployment to chore/remove-lazy-loading-from-dashboards - jaffle_db_pg_13 PR #10102 May 17, 2024 09:13 — with Render Abandoned
@joaoviana joaoviana added the 🖥 frontend This issue requires changes to the frontend label May 17, 2024
@owlas owlas temporarily deployed to chore/remove-lazy-loading-from-dashboards - headless-browser PR #10102 May 17, 2024 09:13 — with Render Destroyed
Copy link

netlify bot commented May 17, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit 427b55e
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/66471fadd8a5b800080ab35d

@owlas owlas temporarily deployed to chore/remove-lazy-loading-from-dashboards - lightdash PR #10102 May 17, 2024 09:15 — with Render Destroyed
@joaoviana joaoviana merged commit 60d06d7 into main May 20, 2024
48 of 52 checks passed
@joaoviana joaoviana deleted the chore/remove-lazy-loading-from-dashboards branch May 20, 2024 08:23
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.1097.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

sentry-io bot commented May 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. ak(react-dom/cjs/react-dom.production) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 frontend This issue requires changes to the frontend released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants