fix: handle filter bys for invalid dates/empty #10097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlas
requested a deployment
to
fix/filter-to-by-invalid-date - jaffle_db_pg_13 PR #10097
Render
Abandoned
owlas
deployed
to
fix/filter-to-by-invalid-date - headless-browser PR #10097
Render
Active
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
magnew
approved these changes
May 17, 2024
packages/common/src/utils/filters.ts
Outdated
| value: any, | ||
| ) => | ||
| isDimension(item) && | ||
| Object.values(TimeFrames).includes(item.timeInterval as TimeFrames) && |
There was a problem hiding this comment.
Is this just checking its a date type? Could you use isDateItem?
There was a problem hiding this comment.
Yes... my intellisense just wasn't working 😥 thank you!
owlas
deployed
to
fix/filter-to-by-invalid-date - headless-browser PR #10097
Render
Active
joaoviana
force-pushed
the
fix/filter-to-by-invalid-date
branch
from
e142e52
to
2f8b1cf
Compare
owlas
deployed
to
fix/filter-to-by-invalid-date - headless-browser PR #10097
Render
Active
owlas
temporarily deployed
to
fix/filter-to-by-invalid-date - headless-browser PR #10097
Render
Destroyed
owlas
temporarily deployed
to
fix/filter-to-by-invalid-date - lightdash PR #10097
Render
Destroyed
lightdash-bot
pushed a commit
that referenced
this pull request
May 20, 2024
## [0.1097.1](0.1097.0...0.1097.1) (2024-05-20) ### Bug Fixes * handle filter bys for invalid dates/empty ([#10097](#10097)) ([2c3a193](2c3a193))
|
🎉 This PR is included in version 0.1097.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10096
Description:
Steps to reproduce:
Fix for a chart
fix-chart.mov
Fix for a dashboard
fix-dashboard.mov
Reviewer actions