chore: persist menu in DOM #969
Conversation
dennyscode
added
the
feature
|
Hey! Those are your new endpoints: https://feat-lf7878jumpernextjsreitera.jumper.exchange |
There was a problem hiding this comment.
This is unfortunate, but I wasted too much time with the MUI clickawaylistener and decided to drop it in favor of a component which handles just that.
There was a problem hiding this comment.
Would prefer to remove the div to be able to keep the click on the widget and not the double click
There was a problem hiding this comment.
Would prefer to remove the div to be able to keep the click on the widget and not the double click
| }} | ||
| /> | ||
| </MenuToggle> | ||
| </NavbarButtonsContainer> | ||
| <MainMenu anchorEl={mainMenuAnchor.current} /> |
There was a problem hiding this comment.
why changing the JSX org on this?
| @@ -82,7 +82,10 @@ export const WallettButtons = () => { | |||
| <ConnectButton | |||
| // Used in the widget | |||
| id="connect-wallet-button" | |||
| onClick={handleWalletSelectClick} | |||
| onClick={(event) => { | |||
| event.stopPropagation(); | |||
There was a problem hiding this comment.
Why adding this? Is it related to the clickAwayListener?
tcheee
removed
wip
…menus-appear-in-dom
|
Small bug found on the feature branch when clicking on the menu, the page is scrolling to the bottom. |
tcheee
deleted the
LF-7878-jumper-next-js-re-iteration-make-menus-appear-in-dom
branch
Ticket: https://lifi.atlassian.net/browse/LF-7878