Add UV_INSTALL guard #4387
Open
Add UV_INSTALL guard #4387
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Apr 22, 2024
| install(EXPORT libuvConfig | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/libuv | ||
| NAMESPACE libuv::) | ||
|
|
||
| if(LIBUV_BUILD_SHARED) |
There was a problem hiding this comment.
I think this belongs inside the UV_INSTALL block, no?
There was a problem hiding this comment.
Yes that belongs inside a UV_INSTALL block also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a UV_INSTALL guard. I believe I have covered all cases of INSTALLs. It defaults to ON and as such the default behavior hasn't changed
I required this as I'm currently packaging my libraries for production and needed to set up each dependency install manually as I have a custom include / lib prefix
Cheers for a great library!! I have learnt much from it