Make rewrite_urls more precise with regard to backslash removal and support "new" subdomain. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function description and add another test-case.
|
Added another commit to support "new.reddit.com"; discovered on |
mikupls
changed the title
spikecodes
reviewed
May 21, 2022
|
Anything else that is needed here? |
|
Sorry this has been on the backburner. I'm going through outstanding issues and PRs and intend to get to this one soon. Bleiben Sie dran. |
|
Thanks. Looks like this patch still applies cleanly. Don't expect me to be able to explain the regexes after a year though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust function description and add another test-case.
Addresses #475 and relates to #281.
So we have tests for both observed breakages now. However, now that I understand a bit more what is going on here, this solution is also far from perfect. It will start breaking again once someone intentionally puts
\_into a comment AFAICT.The intention of the function is probably to limit the scope of the regex replacement to
<a></a>elements. However operating with regexes on HTML is known to be tricky (or "impossible"). I propose we live with this intermediary solution until someone finds another relevant breakage.