Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential Null pointer dereference in test-time.c #1614

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix potential Null pointer dereference in test-time.c #1614

wants to merge 2 commits into from

Conversation

icy17
Copy link
Contributor

@icy17 icy17 commented Apr 10, 2024

No description provided.

azat
azat reviewed Apr 15, 2024
View reviewed changes
test/test-time.c Show resolved Hide resolved
azat
azat reviewed Apr 29, 2024
View reviewed changes
test/test-time.c
if (i == 1 && called >= NEVENT) {
return EXIT_SUCCESS;
} else {
return EXIT_FAILURE;
}
err:
if (base)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

events should be freed first, otherwise this will cause use-after-free

azat
azat requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icy17 @azat