Plug memory leaks #2183
Plug memory leaks #2183
Conversation
If zstd support exists, zstd_dstream has to be freed like other streams.
If parsing fails, free the specific XML parser.
Free archive reader before allocating a new one.
| @@ -3316,8 +3319,10 @@ expat_read_toc(struct archive_read *a) | |||
|
|
|||
| d = NULL; | |||
| r = rd_contents(a, &d, &outbytes, &used, xar->toc_remaining); | |||
| if (r != ARCHIVE_OK) | |||
| if (r != ARCHIVE_OK) { | |||
There was a problem hiding this comment.
I'm not sure about this. This is certainly right if rd_contents returns ARCHIVE_FATAL, but if it returns something less serious, should we really release the parser here?
There was a problem hiding this comment.
In line 3340 it's released in every case as well. The variable parser is local and allocated in line 3302. I'd assume that it cannot be used outside and should be released.
There was a problem hiding this comment.
At least that's how I understand the code. I don't mind being corrected. In fact, it would be better to get this right at the first attempt.
There was a problem hiding this comment.
Yes, you're right. Since parser is local, we need to be certain to clean it up here. Good catch!
| @@ -3316,8 +3319,10 @@ expat_read_toc(struct archive_read *a) | |||
|
|
|||
| d = NULL; | |||
| r = rd_contents(a, &d, &outbytes, &used, xar->toc_remaining); | |||
| if (r != ARCHIVE_OK) | |||
| if (r != ARCHIVE_OK) { | |||
There was a problem hiding this comment.
Yes, you're right. Since parser is local, we need to be certain to clean it up here. Good catch!
The parsers for 7zip and xar contain memory leaks. Also the testsuite 7zip leaks memory. Plug them.
Noticed while running test suite with address sanitizer on Linux.