reconnect_nodes with an unordered_set #1888
Open
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @friedmud - got any time to check this out? |
|
This PR has been marked "do not merge" since we are no longer accepting PRs into the |
We don't actually need an ordering here, and count/insert/etc operations in O(1) instead of O(log(N)) might be nice.
roystgnr
force-pushed
the
reconnect_unordered_nodes
branch
from
2b8a7ae
to
04a88e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need an ordering here, and count/insert/etc
operations in O(1) instead of O(log(N)) might be nice.
@friedmud, try this on the case from #1859 and see if it chops anything off the write_nodesets time?
This might be another pessimization instead but it's an easy enough change to be worth trying.