Improved performance and reduced memory usage #1238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on performance improvements around memory usage.
Scenes with a large number of colliding pairs will benefit most from these changes.
On the
stress3, stress4
examples using thebenchmark
command in Node running on my Mac M1 Air:Other examples show smaller improvements as they tend to have a much lower number of colliding pairs.
Changes
Pairs.update
Pair.id
formatcollision.supports
as belowMigration
Matter.Collision
usecollision.supportCount
instead ofcollision.supports.length
for active supportsMatter.Pair
usepair.contacts
instead ofpair.activeContacts
Matter.Pair
usepair.contactCount
instead ofpair.contacts.length
for active contactsPair.id
format has changed