Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why delete chamfer from options? #1092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

itgoldman
Copy link

@itgoldman itgoldman commented Mar 5, 2022

deleting properties from options prevents user from passing same options to several bodies.

@wilcooo
Copy link

wilcooo commented Nov 15, 2023

I agree that this is weird. The reasoning might be that we don't want/need the chamfer property on the created body (and a body clones all the options properties). However, Body.create will always create a chamfer property anyway, set to null... This property doesn't seem to be used anywhere, it might be just there to make the linter happy.

To make this consistent, this PR should be merged or chamfer should be deleted from the "default" body options in Body.create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants